cosmos / cosmos/evm

Remove Custom ERC20 Signer Function

Open
#519 1 comment 0 reactions 0 assignees View on GitHub
ia
Dominant language
Go
Stars
164
Forks
213
Avg merge
3d 58m
Merged PRs (30d)
12

Description

Remove this custom signer function for converting ERC20s and replace it with a precompile call: [https://github.com/cosmos/evm/blob/3977168b066e13dda869721bf0b7bab8b057f6ad/encoding/config.go#L35](https://github.com/cosmos/evm/blob/3977168b066e13dda869721bf0b7bab8b057f6ad/encoding/config.go#L35).

We should have a generalized GetSigner function for all EVM transaction, and the placement of this one is purely arbitrary.

Contributor guide

Open the contributing guide

Research direction

Start in encoding/config.go at the linked custom ERC20 signer function and trace how EVM transactions obtain signers. Review the precompile call and determine how a generalized GetSigner function should cover all EVM transactions. Done means the custom ERC20-specific signer is removed and signer resolution uses the generalized path.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
blockchain
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.