corvus-dotnet / corvus-dotnet/Corvus.Testing

Improve locking code in FunctionsController

Open
#79 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
13
Forks
11
PR merge metrics
No merged PRs in 30d

Description

During a review of #78, @mwadams raised concerns about the locking code in `FunctionsController`.

_I realise this hasn't changed, but this should probably be a lock with a timeout to stop the specs hanging for ever (until the specrunner times out) in the event of a failure or deadlock._
_Fortunately @idg10 has a TimedLock which may even have made it into Corvus._

and

_Similarly it feels like we should have timeouts on these. I also worry about locking these actual objects rather than proxies for them. Deadlocks can occur if the implementation decides to take locks on itself internally at some point._

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.