corvus-dotnet / corvus-dotnet/Corvus.Tenancy
Dispose KeyVaultClient after use
- Dominant language
- C#
- Stars
- 6
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
We create a `KeyVaultClient` in these locations:
https://github.com/corvus-dotnet/Corvus.Tenancy/blob/75d573380a9b57ee06ee89fae75e0b06d870b670/Solutions/Corvus.Azure.Cosmos.Tenancy/Corvus/Azure/Cosmos/Tenancy/Internal/TenantCosmosContainerFactory.cs#L249
https://github.com/corvus-dotnet/Corvus.Tenancy/blob/49bcd6f419817d29fb1edad880e9a217abe9853f/Solutions/Corvus.Azure.Gremlin.Tenancy/Corvus/Azure/GremlinExtensions/Tenancy/Internal/TenantGremlinContainerFactory.cs#L235
https://github.com/corvus-dotnet/Corvus.Tenancy/blob/b379646f77f43fa864973d3deb2457d53d9e729a/Solutions/Corvus.Azure.Storage.Tenancy/Corvus/Azure/Storage/Tenancy/Internal/TenantCloudBlobContainerFactory.cs#L274
But we do not dispose it in any of them. We should work out whether disposing in situ is fine, or whether this is one of those more problematic scenarios where this is essentially an `HttpClient` in disguise that we need to hang onto and reuse. And if the latter, do we need to arrange to share the instance across all of these usages?
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.