corvus-dotnet / corvus-dotnet/Corvus.Retry

Review retry functionality

Open
#63 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
4
Forks
1
PR merge metrics
No merged PRs in 30d

Description

There are three different ways in which we currently support retrying of tasks:

- `Retriable.Retry`
- `RetriableTaskRunner`
- `RetryTaskFactory`

We should review which of these are necessary and remove those which aren't.

There is also some code in the `RetriableTaskRunner` which firstly blocks the thread when sleeping and then uses `RunSynchronously` to block until the task is complete. If the decision is made that this code should not be removed, we should review the implementation.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by comparing the three retry entry points named in the issue: Retriable.Retry, RetriableTaskRunner, and RetryTaskFactory, and trace how each is used. Determine which APIs are necessary and whether RetriableTaskRunner should remain; if it does, review its blocking sleep and RunSynchronously behavior. Done means the unnecessary paths are removed or the remaining implementation is clearly reviewed and updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.