corvus-dotnet / corvus-dotnet/Corvus.Deployment

BUG: Assert-AzureServicePrincipalForRbac when saving credentials to Key Vault

Open
#69 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
PowerShell
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Due to the line below, when saving updated service principal credentials to Key Vault the `appId` field is null - rendering the stored credential details useless - it works fine when updating app registration credentials.

https://github.com/corvus-dotnet/Corvus.Deployment/blob/df126c4e27ffa3bb43ea967c8345ab8ff4085e94/module/functions/azure/aad/Assert-AzureServicePrincipalForRbac.ps1#L204

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.