cortex-lab / cortex-lab/phylib
Question about suppressing errors in `model.py`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 16
- Forks
- 30
- PR merge metrics
- No merged PRs in 30d
Description
In model.py there is a with np.errstate() that suppresses warnings about dividing by 0 except for the instance when we are doing 0/0 since by IEEE standards that is defined as a separate type of error.
Should we update this np.errstate() to account for both or should we not suppress the invalid state?
Thank you in advance
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the np.errstate() block in model.py at lines 1089-1091 and trace the calculation it surrounds. Determine whether divide-by-zero and invalid-state warnings should be handled consistently; done means the expected warning behavior is decided and the issue's question is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100