ProbeView shows multiple shanks in the case of staggard channel locations.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 430
- Forks
- 187
- Avg merge
- 2h 31m
- Merged PRs (30d)
- 2
Description
This isn't a major bug and I don't think its particularly easy to solve, but am adding here as a note for posterity as the behaviour is a little confusing.
If you are using some probes with staggered channel locations (e.g. 3A) with channel layout such as:
e.g. x-axis displacement of (0, 16, 32, 48) um, then the ProbeView, working from the channel locations, displays them as if they are on separate shanks:
This can make it seem like kilosort/phy thought it was from a 4-shank probe. A quick fix might be to add labels giving the x-axis 'shank' locations on the plot. Otherwise I think the ProbeView might need to be reworked to solve this properly, but this is not a major issue and that would be a lot of work.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ProbeView and its handling of channel locations; reproduce the staggered layout using x-axis displacements of 0, 16, 32, and 48 µm and compare the rendering with the supplied images. Determine whether labeling x-axis shank locations is sufficient or whether the view needs reworking; the issue is done when staggered channels no longer misleadingly appear as a four-shank probe.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100