cortex-lab / cortex-lab/phy

Incorrect channel positions in TraceImageView?

Open
#1,029 0 comments 0 reactions 1 assignee View on GitHub

@rossant is already working on this.

Since Sep 28, 2020.

area: visualization type: bug
Dominant language
Python
Stars
430
Forks
187
Avg merge
2h 31m
Merged PRs (30d)
2

Description

Hi,

I'm using phy==2.0b1 on kilosort2 output for neuropixels data, and the ordering of channels in the TraceImageView seems incorrect. It appears as if the channel positions were not used to reorder the traces when generating the image (since the bank/probe-location changes back and forth every two channel):

image

Note that channels are ordered correctly on the TraceView:
image

And the channel positions stored in both TraceView.channel_positions and TraceImageView.channel_positions seem to be correct.
Any idea what might be going on, and whether I'm missing something?
Thanks a lot!
Tom

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.