coreybutler / coreybutler/node-windows

no way to specify service logon info

Open
#39 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.9k
Forks
368
PR merge metrics
No merged PRs in 30d

Description

Thanks for this elegant module. One thing that threw me while reading the doc is the user attribute. I assumed it was transferred over to the service logon information on the installed service, but it's not. Instead it's just the user account used to run the service setup command.

That being said, having the ability to programattically specify the service logon credentials is something I really need. Why not create another set of credentials in the config for that? It looks like it would be a quite simple modification, given that winsw supports this (under the serviceaccount xml attribute.)

One potential security issue is that the user account and password are placed in clear text in the xml file, so if this is done perhaps there would be a post install hook that munges the password in xml?

(P.S. Also, this is minor, but would be great if generateXml created xml that was formatted nicely for readability.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.