loading button dispose calls undefined method
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 19
- Forks
- 18
- Avg merge
- 1h 6m
- Merged PRs (30d)
- 549
Description
We've been having js errors while using the loadingbutton; a function called 'removeData' is called, but is not defined. When looking at the code in loading-button.js, we see the following snippet.
dispose() {
Data.removeData(this._element, DATA_KEY)
this._element = null
}
Data (from dom/data.js) does not define 'removeData', it does define 'remove'.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in loading-button.js at dispose() and compare its Data call with the API defined in dom/data.js. Confirm the disposal path no longer calls an undefined method, then run the relevant loading-button tests or reproduce the reported JavaScript error to verify disposal completes cleanly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100