coreui / coreui/coreui-free-react-admin-template
npm.yml's Node version matrix has no effect
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 5k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
In npm.yml, the matrix defines node-version: [16.x, 17.x, 18.x], but setup-node receives node-version: ${{ env.node-version }}. Since it's undefined in env:, setup-node skips installation and all matrix jobs run on the runner's default Node.
Because of this, build (ubuntu-latest, 16.x) is green in the latest scheduled run despite vite ^8.2.1 requiring Node ^20.19.0 || >=22.12.0.
Wiring matrix.node-version as-is would break the build, so the matrix values need to be updated as well. Would a PR fixing both be welcome?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open npm.yml and compare the matrix node-version values with the value passed to setup-node. Update the workflow so setup-node uses the matrix value, then align the matrix versions with Vite's required Node versions and verify each matrix build uses the intended runtime.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs, react, vite
- Domain
- build-system, ci-cd
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 74/100