Consider improving `with_mount_unit` semantics
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 974
- Forks
- 296
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 9
Description
Created originally in Butane by @jlebon: https://github.com/coreos/butane/issues/532
Currently, with_mount_unit creates a mount unit with the What set to the same device provided to the filesystem block that uses it. But the device name used there may not be stable across updates (e.g. /dev/sda).
One thing we could do is have the generated mount unit use the label defined on the filesystem instead (i.e. /dev/disk/by-label/$LABEL). If the label is not set, and we detect the device name as "unstable", we can fallback to the device name but emit a warning.
See also: https://github.com/coreos/fedora-coreos-tracker/issues/1732
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the filesystem block handling and the with_mount_unit entry point that generates the mount unit. Compare the device currently used for What with the proposed label-based path and the unstable-device fallback. Done means the semantics are defined, warnings are emitted where required, and the linked Butane and Fedora CoreOS concerns are addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100