coreos / coreos/ignition

Support sfdisk backend for partitioning

Open
#1,926 4 comments 1 reaction 1 assignee View on GitHub

@prestist is already working on this.

Since Aug 26, 2024.

kind/enhancement
Dominant language
Go
Stars
974
Forks
296
Avg merge
6d 14h
Merged PRs (30d)
9

Description

sfdisk is part of util-linux and has supported GPT partitioning for a while now. It'd be desirable to support using sfdisk instead of sgdisk for partitioning for OSes that want to shed that dependency.

Proposal:

  1. add a new sfdisk package that implements the same API as the sgdisk one
  2. support a compile option to change the default backend to use from sgdisk to sfdisk
  3. support a kernel argument option (e.g. ignition.partition-backend=(sfdisk|sgdisk)) to override compile-time defaults
  4. once we have some confidence in the code, change the upstream default to sfdisk and declare the sgdisk backend deprecated
  5. after a reasonable window, drop support for the sgdisk backend

On the FCOS side, we can start using the sfdisk backend in some of the non-production streams to get some early testing, and if deemed necessary, bake it in the next stream as well.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.