coreos / coreos/ignition

Drop systemd service disablement workaround

Open
#1,440 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
974
Forks
296
Avg merge
6d 14h
Merged PRs (30d)
9

Description

Ignition supports modifying service enablement by injecting preset files. However, disabling services hasn't worked because, until recently, systemd has been only using preset files to enable services and not disable them. As a result, we've added some code in Ignition to workaround this.

Now, systemd has made this behaviour configurable so that preset files are also used to disable systemd units, and Fedora rawhide has started to opt in. The eventual goal is to make it the default upstream.

As a result, we should be able to remove our workaround at some point. However, we need to be aware of other distributions where Ignition may rev faster than systemd. There may be also other non-Fedora-based distros which may not have opted in (but we could document that we expect them to opt in if upstream takes too long to change defaults).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the workaround introduced in Ignition PR #1352 and the linked systemd preset behavior changes first. Determine which distributions support preset-based disabling before removing the workaround, and document any required systemd behavior or distribution expectations. Done means the workaround is safely removed or its compatibility constraints are recorded.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devops, operating-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.