Centralize OnFailure= into target units once systemd supports it
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 974
- Forks
- 296
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 9
Description
We initially had to remove them from target units in https://github.com/coreos/ignition-dracut/pull/188 because of a systemd change: https://github.com/systemd/systemd/issues/14142. This was then reverted in systemd: https://github.com/systemd/systemd/issues/14142#issuecomment-675710064. We should follow-up on this and put back OnFailure= in the target units instead of spamming it in every systemd unit we have and will have.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the target units and the systemd issue linked in the report, then inspect the systemd unit definitions in Ignition for repeated OnFailure= entries. Done means OnFailure= is centralized in the target units rather than repeated across every unit, while preserving the behavior that motivated the original change.
Written by the indexing model from the issue text.
Assessment
- Domain
- devops, operating-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100