coreos / coreos/ignition

Be consistent about passing --log-to-stdout

Open
#1,048 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
974
Forks
296
Avg merge
6d 14h
Merged PRs (30d)
9

Description

The files unit passes --log-to-stdout, but the disks unit doesn't. The option was added to the files stage invocation when we weren't yet enabling the disks stage, but the commit history (d3d31218e4aa51ad9dcff6d0684c7521f9eebe25) doesn't say why it was added at all. We should be consistent about passing the option.

@dustymabe, can you add any context about why it was enabled?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the files and disks unit invocations to see how each passes --log-to-stdout, then inspect commit d3d31218e4aa51ad9dcff6d0684c7521f9eebe25 and the related stage code for context. Done means the option's intended behavior is established and both unit invocations handle it consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
operating-systems
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.