Job completion channel not closed
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2.7k
- Forks
- 338
- PR merge metrics
- No merged PRs in 30d
Description
Shouldn't jobComplete be closing the channel after it is done with it here?
func (c *Conn) jobComplete(signal *dbus.Signal) {
...
c.jobListener.Lock()
out, ok := c.jobListener.jobs[job]
if ok {
out <- result
delete(c.jobListener.jobs, job)
}
c.jobListener.Unlock()
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Conn.jobComplete and tracing how jobListener.jobs channels are created and consumed. Inspect the surrounding job completion flow to determine the expected channel lifecycle and whether closing it is safe after sending result. Done means the completion channel behavior is correct and covered by the relevant existing tests, if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100