coreos / coreos/go-systemd

Use (*Conn) AddMatchSignal instead of BusObject().Call("org.freedesktop.DBus.AddMatch"

Open
#388 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
2.7k
Forks
338
PR merge metrics
No merged PRs in 30d

Description

Now connection has better API for adding match signals, so we should make use of it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for uses of BusObject().Call("org.freedesktop.DBus.AddMatch") and read the surrounding connection-handling code. Replace the legacy call with (*Conn) AddMatchSignal, then run the repository's existing tests to confirm the D-Bus match behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.