login1 command wrappers do not return the call error
Open
Nobody has claimed this yet.
kind/breaking-api
- Dominant language
- Go
- Stars
- 2.7k
- Forks
- 338
- PR merge metrics
- No merged PRs in 30d
Description
The pattern used in other packages here is something like return c.object.Call(...).Err but the wrapper methods in login1 just swallow any errors.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the login1 package and compare its wrapper methods with the other packages' pattern of returning c.object.Call(...).Err. Update the wrappers so call errors are returned rather than swallowed, and verify that each affected method propagates the call error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100