coreos / coreos/coreos-assembler

podman.workflow test incorrect parsing of `podman rmi` output

Open
#4,095 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
393
Forks
193
Avg merge
17h 6m
Merged PRs (30d)
5

Description

Yields results in the logs of tests that looks like:

--- PASS: podman.workflow (367.30s)                                                           
    --- PASS: podman.workflow/run (306.45s)                                                   
            cluster.go:151: Trying to pull quay.io/fedora/fedora:latest...                    
            cluster.go:151: Getting image source signatures                                   
            cluster.go:151: Copying blob sha256:2d1766c96a03a5c0d88cb51417d01b1a11e0245c6c8a5dfe48a8a1629d64e8fc
            cluster.go:151: Copying config sha256:818c0c393dd42bdb323b3344c8a3db27597e00d8dc342e8253aa2838b1d5b570
            cluster.go:151: Writing manifest to image destination                             
    --- PASS: podman.workflow/exec (0.37s)                                                    
    --- PASS: podman.workflow/stop (10.57s)                                                   
    --- PASS: podman.workflow/remove (0.34s)                                                  
    --- PASS: podman.workflow/delete (0.42s)                                                  
            cluster.go:151: grep: quay.io/fedora/fedora:latest: No such file or directory     
            cluster.go:151: bash: line 2: Deleted:: command not found

Basically the code isn't parsing the outupt of podman rmi correctly any longer (podman must have changed).

[dustymabe@media ~]$ podman rmi quay.io/fedora-testing/fedora-bootc:rawhide-minimal
Untagged: quay.io/fedora-testing/fedora-bootc:rawhide-minimal
Deleted: 34871ba538d55e6c5f9e5e932c8810546f01fdaca9a6e41e84fda0c99fc00ce2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at mantle/kola/tests/podman/podman.go around line 218, where the podman rmi output is parsed. Run the podman workflow test and compare the parser with the shown Untagged and Deleted output. Done means the test no longer emits the image path or "Deleted:" as shell commands.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.