coreos / coreos/coreos-assembler
Add Tests to ensure that kernel arguments persist
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 393
- Forks
- 193
- Avg merge
- 17h 6m
- Merged PRs (30d)
- 5
Description
As a developer I would like to have test coverage to insure that no regressions are made around kargs.
So that new feature development can happen with the assurance of CI verifying that no regressions have taken place around the kargs functionality.
This stems from an issue where a user
-
Installed bootstrap-in-place cluster
-
Appended kernel arguments (Ip/namespace in this case)
-
Then found after booting the server was still using a dhcp ip
This was later fixed by the MR
Lets add some test coverage to insure that the kargs are functioning as expected.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked MR #3169, which fixed the kernel-argument behavior, and trace the bootstrap-in-place flow it changed. Add regression coverage showing that appended kernel arguments persist after boot, then run the relevant project test suite to verify CI catches the original DHCP-versus-static-argument failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- build-system, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 42/100