coreos / coreos/coreos-assembler

enhancements to how kola handles certain failure scenarios

Open
#2,620 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
393
Forks
193
Avg merge
17h 6m
Merged PRs (30d)
5

Description

From https://github.com/openshift/os/pull/685#discussion_r770681213

I'm thinking we should extend kola to handle these kinds of checks so they're non-fatal but still loud. Some ideas:

  • have kola check test output for KOLAWARNING: ... and reprint the warning on the console.
  • add a warn-on-rc: N field to kola test JSON where if a test exits with the given code, kola prints WARN: $testname instead of FAIL: $testname.

We can then have kola e.g. touch a file or print a report of warnings and the Slack notifier in the pipelines can check for this file and tweak the notification.

cc: @jlebon @dustymabe

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing kola's handling of test output, exit codes, and test JSON, then review how the pipeline's Slack notifier could consume a warning report or file. Compare the proposed KOLAWARNING output and warn-on-rc behavior, and define completion as non-fatal failures being visibly reported while the notifier can distinguish warnings from failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
ci-cd, testing-qa, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.