coreos / coreos/coreos-assembler

support Distros key in JSON headers of external tests

Open
#2,521 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
393
Forks
193
Avg merge
17h 6m
Merged PRs (30d)
5

Description

In openshift/os#661 it was discussed that some of the tests that are present in FCOS are not being shared/run by RHCOS, since the symlinks from the fedora-coreos-config submodule to the tests directory are missing.

@jlebon proposed extending the JSON headers of the external tests to include support for the same Distros key that is used in the native kola tests.

This way we could symlink the entire fedora-coreos-config/tests directory in openshift/os and be able to sanely share the tests between the two projects.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the external-test JSON header parsing and the native kola test handling for the Distros key. Compare how the two paths select tests, then verify that external tests honor Distros so the fedora-coreos-config/tests directory can be shared without missing symlinks.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.