coreos / coreos/coreos-assembler

Data race in github.com/coreos/mantle/kola/tests/ignition.setupIgnitionConfig

Open
#2,298 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
393
Forks
193
Avg merge
17h 6m
Merged PRs (30d)
5

Description

==================
WARNING: DATA RACE
Write at 0x00000467f460 by goroutine 89:
  github.com/coreos/mantle/kola/tests/ignition.setupIgnitionConfig()
      /root/containerbuild/mantle/kola/tests/ignition/mount.go:154 +0xc88
  github.com/coreos/mantle/kola/tests/ignition.testMountDisks()
      /root/containerbuild/mantle/kola/tests/ignition/mount.go:55 +0x49
  github.com/coreos/mantle/kola.runTest()
      /root/containerbuild/mantle/kola/harness.go:946 +0x821
  github.com/coreos/mantle/kola.runProvidedTests.func1()
      /root/containerbuild/mantle/kola/harness.go:461 +0x6f
  github.com/coreos/mantle/harness.tRunner()
      /root/containerbuild/mantle/harness/harness.go:441 +0x256

Previous write at 0x00000467f460 by goroutine 91:
  github.com/coreos/mantle/kola/tests/ignition.setupIgnitionConfig()
      /root/containerbuild/mantle/kola/tests/ignition/mount.go:154 +0xc88
  github.com/coreos/mantle/kola/tests/ignition.testMountPartitions()
      /root/containerbuild/mantle/kola/tests/ignition/mount.go:89 +0x49
  github.com/coreos/mantle/kola.runTest()
      /root/containerbuild/mantle/kola/harness.go:946 +0x821
  github.com/coreos/mantle/kola.runProvidedTests.func1()
      /root/containerbuild/mantle/kola/harness.go:461 +0x6f
  github.com/coreos/mantle/harness.tRunner()
      /root/containerbuild/mantle/harness/harness.go:441 +0x256

Goroutine 89 (running) created at:
  github.com/coreos/mantle/harness.(*H).Run()
      /root/containerbuild/mantle/harness/harness.go:479 +0x72c
  github.com/coreos/mantle/harness.(*Suite).runTests.func1()
      /root/containerbuild/mantle/harness/suite.go:289 +0x124
  github.com/coreos/mantle/harness.tRunner()
      /root/containerbuild/mantle/harness/harness.go:441 +0x256
  github.com/coreos/mantle/harness.(*Suite).runTests()
      /root/containerbuild/mantle/harness/suite.go:287 +0x311
  github.com/coreos/mantle/harness.(*Suite).Run()
      /root/containerbuild/mantle/harness/suite.go:274 +0x549
  github.com/coreos/mantle/kola.runProvidedTests()
      /root/containerbuild/mantle/kola/harness.go:467 +0x7ad
  github.com/coreos/mantle/kola.RunTests()
      /root/containerbuild/mantle/kola/harness.go:490 +0x2e4
  main.runRun()
      /root/containerbuild/mantle/cmd/kola/kola.go:188 +0x8e
  github.com/spf13/cobra.(*Command).execute()
      /root/containerbuild/mantle/vendor/github.com/spf13/cobra/command.go:840 +0x505
  github.com/spf13/cobra.(*Command).ExecuteC()
      /root/containerbuild/mantle/vendor/github.com/spf13/cobra/command.go:945 +0x492
  github.com/spf13/cobra.(*Command).Execute()
      /root/containerbuild/mantle/vendor/github.com/spf13/cobra/command.go:885 +0x215
  github.com/coreos/mantle/cli.Execute()
      /root/containerbuild/mantle/cli/cli.go:67 +0x220
  main.main()
      /root/containerbuild/mantle/cmd/kola/kola.go:130 +0x4a

Goroutine 91 (running) created at:
  github.com/coreos/mantle/harness.(*H).Run()
      /root/containerbuild/mantle/harness/harness.go:479 +0x72c
  github.com/coreos/mantle/harness.(*Suite).runTests.func1()
      /root/containerbuild/mantle/harness/suite.go:289 +0x124
  github.com/coreos/mantle/harness.tRunner()
      /root/containerbuild/mantle/harness/harness.go:441 +0x256
  github.com/coreos/mantle/harness.(*Suite).runTests()
      /root/containerbuild/mantle/harness/suite.go:287 +0x311
  github.com/coreos/mantle/harness.(*Suite).Run()
      /root/containerbuild/mantle/harness/suite.go:274 +0x549
  github.com/coreos/mantle/kola.runProvidedTests()
      /root/containerbuild/mantle/kola/harness.go:467 +0x7ad
  github.com/coreos/mantle/kola.RunTests()
      /root/containerbuild/mantle/kola/harness.go:490 +0x2e4
  main.runRun()
      /root/containerbuild/mantle/cmd/kola/kola.go:188 +0x8e
  github.com/spf13/cobra.(*Command).execute()
      /root/containerbuild/mantle/vendor/github.com/spf13/cobra/command.go:840 +0x505
  github.com/spf13/cobra.(*Command).ExecuteC()
      /root/containerbuild/mantle/vendor/github.com/spf13/cobra/command.go:945 +0x492
  github.com/spf13/cobra.(*Command).Execute()
      /root/containerbuild/mantle/vendor/github.com/spf13/cobra/command.go:885 +0x215
  github.com/coreos/mantle/cli.Execute()
      /root/containerbuild/mantle/cli/cli.go:67 +0x220
  main.main()
      /root/containerbuild/mantle/cmd/kola/kola.go:130 +0x4a
==================

Seen in CI of https://github.com/coreos/coreos-assembler/pull/2283.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in kola/tests/ignition/mount.go at setupIgnitionConfig on line 154, then compare testMountDisks and testMountPartitions, which the report shows running concurrently. Run the affected Kola tests with the race detector and consider the issue complete when this reported race no longer appears.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.