coreos / coreos/coreos-assembler

Have kola check for badness on console output in a streaming fashion

Open
#1,366 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
393
Forks
193
Avg merge
17h 6m
Merged PRs (30d)
5

Description

Instead of waiting for the test to finish before doing the console checks, it would be nice if kola did it while the console output streamed (on platforms that support it). That way we could error out the test early.

We just had a situation where the system entered the emergency console, timed out after 5 minutes, rebooted, then passed on the second try. The whole test logic itself seems like it passed, but then kola failed the test in the end because it found the emergency prompt.

(A separate question we need to explore here is whether we actually want the auto-reboot after 5 minutes thing; though we'd want to do this kola fix first before dropping that.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing kola's current console-output checks and how streamed output is handled. Done means bad console output is detected while the test runs, allowing early failure on supported platforms, while preserving the existing behavior on unsupported platforms.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.