Rework safety guard to support empty EFI component
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 196
- Forks
- 55
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 14
Description
In the automotive use case, some images will have empty EFI components so we should support that.
In https://github.com/coreos/bootupd/issues/994, we added a check that makes sure the EFI component has at least 2 entries, which thus fails.
What we want instead if the following:
- If there are no EFI component found, then we don't include EFI.json
- If there are some EFI component found:
- Check if shim is part of them:
- If it is, then there must be another component (i.e. bootloader) included
- If it's not, do nothing special
- Check if grub is part of them:
- If it is, then there must be shim as another component
- If it's not, do nothing special
- Check if shim is part of them:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the EFI safety guard added for issue #994 and the code that decides whether to include EFI.json. Check the existing tests around EFI components, then cover no components, shim with and without another component, and grub with and without shim; done means empty EFI is accepted while invalid shim/grub combinations remain rejected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100