corejavascript / corejavascript/typeahead.js

Bad html syntax

Open
#247 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
968
Forks
231
PR merge metrics
No merged PRs in 30d

Description

Goog morning,

Using the Nu Html Checker (https://validator.w3.org/nu/), we get 2 validation errors for each typeahead found in the page:

1 - Element pre not allowed as child of element span in this context.
2 - Element div not allowed as child of element span in this context.

It seems that the problem lies on the wrapper **"twiter-typeahead"** being declared as a **span** and thus does not allowing block tags **like** pre or **div**... Just changing it to be a **div** in the **buildHtml** function seems to solve the problem without causing any other problems (as far I have seen).

Would it be possible to apply this change?

Anyway I will apply this fix on my local file, but it would be better if it is addressed also in the official version of this plugin :)

Thank you!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.