corejavascript / corejavascript/typeahead.js

change jQuery to peer dependency?

Open
#182 6 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
968
Forks
231
PR merge metrics
No merged PRs in 30d

Description

I'm having an issue where jQuery 3.3.1 (latest version) is breaking corejs-typeahead. Because I am using the typeahead within a custom React component I'm not yet sure if the latest jQuery is breaking the typeahead just in my specific use case or everywhere.

I do find that if I manually force jQuery 3.2.1 then everything works, but because corejs-typeahead pulls in jQuery as a dependency it tries to install the latest jQuery 3.3.1. Perhaps jQuery could be switched to a peer dependency which would allow more flexibility in users specifying the jQuery version that works best in their projects? At the very least it would make things easier while trying to narrow down the problems caused by dependency changes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.