corejavascript / corejavascript/typeahead.js

Deduplication of common/utils

Open
#165 2 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
JavaScript
Stars
968
Forks
231
PR merge metrics
No merged PRs in 30d

Description

Up until version 0.10.x, `common/utils` was shared by Bloodhound & Typeahead.

From version 0.11.x onwards, Bloodhound & Typeahead are defined as UMD modules, and each module has its own copy of `common/utils`. This results in unnecessary redundancy / bloat.

There's several solutions for this. Personally, I lean towards one of these options :
* Put `common/utils` into a third module that is used as a dependency by both Bloodhound & Typeahead
* Replace `common/utils` by two distinct util classes that are no longer shared between Bloodhound & Typeahead

What do you guys think about this?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.