corcel / corcel/acf

Image __toString not correctly implemented

Open
#65 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
132
Forks
102
PR merge metrics
No merged PRs in 30d

Description

Image extends BasicField, and provides some abstract base methods - `__toString` causes an issue with Image in particular as it invokes `->get()` as get() for `Image` returns an Image instance.

`__toString` must always return a string.

Happy to shoot through a PR. Simplest solution would probably just to overwrite the abstract method __toString in image with something like:

```
/**
* @return string
*/
public function __toString()
{
return $this->url;
}
```

This was covered in #60 but it was closed because it wasn't explained in detail

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.