conventoangelo / conventoangelo/OverKeys

Bug: `customAliases` not working as intended when layout has `"foreign": true`

Open
#188 1 comment 0 reactions 1 assignee Claimed by @conventoangelo View on GitHub
bug
Dominant language
Dart
Stars
244
Forks
24
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

When I press the shortcut, the key with the customAlias name does not light up. Instead, only pressing the corresponding key on the keyboard lights it up. For example, here "Item" is a `customAlias` set to be activated when Ctrl+J is pressed. But it only activates when the button 1 is pressed.

**To Reproduce**

Set layout as:

```JSON
{
...
"userLayouts": [
{
"name": "Test",
"foreign": true,
"keys": [
["Item","","","","","","","","","","","",""],
["","","","","","","","","","","",""],
["","","","","","","","","","",""],
["","","","","","","","","",""],
[" "]
]
}
],
...
```

Set `customAlias` as:

```JSON
{
...
"customAliases": {
"Item": ["Control", "J"]
},
}
```
Set `defaultLayout` as:

```JSON
{
...
"defaultUserLayout": "Test"
}
```

**Expected behavior**

When I press Control+J, the key with the name Item lights up.

**Screenshots**

Not useful.

**Desktop (please complete the following information):**

- Version 0.3.4

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.