controlsfx / controlsfx/controlsfx
Re-integrate tests in 9.0.0 branch
- Dominant language
- Java
- Stars
- 1.7k
- Forks
- 300
- Avg merge
- 16d 17h
- Merged PRs (30d)
- 1
Description
ControlsFX 9.0.0 is getting rid of 2 test classes:
* org.controlsfx.control.JavaFXThreadingRule
* org.controlsfx.control.SearchableComboBoxTest
JavaFXThreadingRule
---
`JavaFXThreadingRule` uses `javafx.swing` module to run tests. Since we do not want to include one extra module just for one test case, it is a good trade-off to remove it unless we have a better reason to integrate it back (or more tests which depend on the said module).
SearchableComboBoxTest
----
`SearchableComboBoxTest` is written using TestFX. For some reason this doesn't work on JDK 9. If someone has experience with TestFX + JDK 9. We could bring this test back.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating org.controlsfx.control.JavaFXThreadingRule and org.controlsfx.control.SearchableComboBoxTest in the 9.0.0 branch. Investigate whether TestFX can run on JDK 9 and whether javafx.swing is justified for the threading rule. Done means the tests are reintegrated without adding an unnecessary module and pass on the supported JDK.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- desktop-dev, testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100