contributte / contributte/datagrid

Part of the state is lost after calling `setRememberState(false)` and then changing a per page limit from the UI

Open
#972 5 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

T: Bug
Dominant language
PHP
Stars
296
Forks
215
PR merge metrics
No merged PRs in 30d

Description

How to reproduce the bug:

  1. Install contributte playground

  2. Add a $grid->setRememberState(false) call into the BasicPresenter

  3. Go to the default view and write down da into the Name filter input

  4. That gives you 54 results, as expected

  5. But then change the pagination to 50 items per page

Suddenly you get an unfiltered result (showing all 1000 records) but with the da still in the Name filter input.

Expected behavior would be not loosing the filter state (keeping it in URL) when the user changes items per page parameter.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the contributte playground by adding setRememberState(false) to BasicPresenter, entering da in the Name filter, and changing the per-page limit. Trace the state handling for that pagination change; done means the filter remains in the URL and the results stay filtered.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.