contributte / contributte/datagrid

setSortableCallback() doesn't work when using default or session sort

Open
#840 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
296
Forks
215
PR merge metrics
No merged PRs in 30d

Description

Doesn't work even when $grid->setRememberState(FALSE); is set.

$qb = $this->ipAddressFacade->createQueryBuilder('ip')

$grid = (new DataGrid)
    ->setPrimaryKey('id')
    ->setDataSource($qb)
    ->setDefaultSort(['ip' => 'ASC']);

$grid->addColumnText('ip', 'IP')
    ->setSortable()
    ->setSortableCallback(function (QueryBuilder $qb, array $sorting): void {
        $qb->addOrderBy('ip.fullIp ', $sorting['ip']);
    });

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the setSortableCallback(), setDefaultSort(), and setRememberState(FALSE) entry points and reproduce the issue with the provided DataGrid and QueryBuilder example. Trace how default or session sorting is applied alongside the callback; done means the callback works correctly for those sorting modes, with regression coverage for the reported setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.