contributte / contributte/datagrid

FilterText filtering with quotation marks

Open
#764 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
296
Forks
215
PR merge metrics
No merged PRs in 30d

Description

Hi,
could be changed behavior in filterText to filtering with quotation marks?
Google like, for example: "not splitted search" and next splitted words

Because simple split by spacing is not enought.

Better could be something like this:

    public function getSplittedWords($value)
    {
        if ($this->hasSplitWordsSearch() === false) {
            return [$value];
        } else {
            preg_match_all('/([^\s"\']+)|"([^"]*)"|\'([^\']*)\'/', $value, $m);
            return array_filter(array_merge($m[1], $m[2], $m[3]));
        }
    }

Regular expression from https://stackoverflow.com/a/366532

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating filterText and the getSplittedWords($value) method in the PHP codebase. Review how filtering currently splits input, then verify the quoted-search behavior described in the issue, including quoted phrases and additional unquoted words. Done means quoted text remains one search term while whitespace-separated terms still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.