contributte / contributte/datagrid
FilterText filtering with quotation marks
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 296
- Forks
- 215
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
could be changed behavior in filterText to filtering with quotation marks?
Google like, for example: "not splitted search" and next splitted words
Because simple split by spacing is not enought.
Better could be something like this:
public function getSplittedWords($value)
{
if ($this->hasSplitWordsSearch() === false) {
return [$value];
} else {
preg_match_all('/([^\s"\']+)|"([^"]*)"|\'([^\']*)\'/', $value, $m);
return array_filter(array_merge($m[1], $m[2], $m[3]));
}
}
Regular expression from https://stackoverflow.com/a/366532
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating filterText and the getSplittedWords($value) method in the PHP codebase. Review how filtering currently splits input, then verify the quoted-search behavior described in the issue, including quoted phrases and additional unquoted words. Done means quoted text remains one search term while whitespace-separated terms still work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100