continuedev / continuedev/continue
The 'Main Branch Enforce PRs' ruleset is disabled, so PRs can merge while require-all-checks-to-pass is failing
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 36k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Hi — I noticed the repo already has a ruleset that would enforce PR checks on main, but it's switched off.
Main Branch Enforce PRs (id 6233045) is set to enforcement: disabled, and it declares exactly what you'd want:
required_approving_review_count: 1
required_status_checks: ["require-all-checks-to-pass", "CLAAssistant"]
Because it's disabled, PRs can land while that check is red. The clearest example is the current main HEAD itself — d0a3c0b6 is the merge commit of #12816:
require-all-checks-to-passcompleted as failure at00:21:31- the PR merged at
00:21:52— 21 seconds later - no approving review
I'm not suggesting a new policy; the policy is already written and correctly targeted. It just needs enforcement flipped to active. (Main Branch Baseline Restrictions, id 6232937, is disabled too.)
I may be missing a reason it was turned off — if it's deliberate, feel free to close this.
(Checked at d0a3c0b626b5bebc3bef4742eec05a0242be0bab. Written with AI assistance.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the repository ruleset settings and inspect Main Branch Enforce PRs (id 6233045), confirming its current enforcement state and required checks. Enable the ruleset, then verify that main requires one approval and the listed checks before merging. Also review Main Branch Baseline Restrictions (id 6232937) for any intentional reason it remains disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100