containers / containers/podman-compose

Integration tests should not use network connectivity if not necessary

Open
#998 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
6.2k
Forks
622
PR merge metrics
No merged PRs in 30d

Description

Currently integration tests do a lot of checks using network connectivity through localhost. This makes tests more brittle because it introduces a race condition: we don't wait for the webserver to fully start up before requests are issued. Most of the time this is fine so far.

Better idea would be to use `echo ` as the container command, possibly wait for container to exit and then check the logs.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.