containers / containers/podman-compose

Ruff and black disagree on what the code should look like

Open
#1,142 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
6.2k
Forks
622
PR merge metrics
No merged PRs in 30d

Description

Just noticed `ruff podman_compose.py` and `black podman_compose.py` generate two different outputs that fail for checks against one-another. As pre-commit checks against black and the ci checks against ruff, and the contribution guide suggests setting up pre-commit, it would be reasonable to either alter pre-commit by replacing black or the ci by replacing ruff.

**To Reproducte**

```
black podman_compose.py
ruff podman_compose.py
```

**Expected behavior**
It should be possible to align the code against a single code formatter.

**Actual behavior**
Ruff and Black disagree on what "properly formatted" looks like.

**Environment:**
- OS: Linux
- podman-compose version 1.3.0
- podman version 4.9.3

**Additional context**

Tested against main branch.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.