containers / containers/nri-plugins

Drop the runtime.patchConfig flag as NRI is on on both runtimes

Open
#749 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
114
Forks
44
Avg merge
1d 8h
Merged PRs (30d)
20

Description

I guess we are reaching the point where the `runtime.patchConfig` is becoming somewhat dead assuming NRI is enabled by default on both container runtimes for a quite a while. I think it must be very old (unsupported) version of the runtime that would require NRI to be turned on manually.

Should we drop the flag? Any concerns @klihub @kad ?

Contributor guide

Open the contributing guide

Research direction

The issue identifies runtime.patchConfig as the entry point, but names no files or tests. Locate its definition and all runtime-specific uses first; done means the obsolete flag is removed without requiring manual NRI enablement on either supported container runtime.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.