containers / containers/nri-plugins

topology-aware: CPU reservation by resource.Quantity always rounded up to next integer

Open
#632 0 comments 0 reactions 1 assignee Claimed by @klihub View on GitHub
Dominant language
Go
Stars
114
Forks
44
Avg merge
1d 8h
Merged PRs (30d)
20

Description

### Bug Description

Partial CPU reservation alway accounted as the rounded up next integer amount. For instance a 750m reservation will effectively reserve a full CPU.

### Expected behavior

Container allocations not in the kube-reserved namespace should not get rejected if the non-reserved portion of CPU has not been fully exhausted by non-kube-system containers.

### Experienced behavior

750m reservation is accounted as 1000m.

### Steps to reproduce the behavior

Steps to reproduce the behavior
1. Reserve 750m CPU
2. Create container with ($available - 750m) CPU request

### Environment

_No response_

### Additional context

Additional information about the bug

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.