containers / containers/bubblewrap

Have a specific exit code for when sandboxing is not possible

Open
#701 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
8.7k
Forks
386
Avg merge
3d 17h
Merged PRs (30d)
11

Description

Since there are a bunch of environments where sandboxing doesn't work like in a libgnome-desktop sandbox or some CIs, we want to do opportunistic sandboxing. We are now doing this in glycin by testing if bwrap was called with SIGSYS (happens in CIs) or if it's STDERR contains a string indicating that spawning failed due to failing to create namespace [glycin!295](https://gitlab.gnome.org/GNOME/glycin/-/merge_requests/295).

While there is no clear answer to what "sandboxing not being available" means, at least for the failed `clone` syscalls it would be good to have a more specific exit code than just `1`. Following the 128+n convention would be one option.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.