containers / containers/Demos

should use && not ;

Open
#74 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
84
Forks
45
PR merge metrics
No merged PRs in 30d

Description

https://github.com/containers/Demos/blob/c0e2da251532aa84c8c0ce9f62d56f3349c1350f/bootc/machine/Containerfile#L3

Otherwise if there's an error at build time (e.g. package download failed) we will just blindly continue on and produce something broken. Yes, shell script sucks :smile:

I tend to have a `build.sh` to start that uses [bash strict mode](http://redsymbol.net/articles/unofficial-bash-strict-mode/) and then `COPY build.sh .` and `RUN build.sh`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Open bootc/machine/Containerfile at line 3 and inspect how the shell commands are chained. Verify the image build stops when a package download fails, and confirm that successful builds still complete normally.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system, devops
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.