containerd / containerd/ttrpc

TestServerRequestTimeout is flaky on Windows

Open
#131 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
664
Forks
86
PR merge metrics
No merged PRs in 30d

Description

`TestServerRequestTimeout` has been intermittently failing in PRs due to differences in deadline comparisons.

Example output from a PR run
```
🇩 coverage
--- FAIL: TestServerRequestTimeout (0.01s)
server_test.go:406: expected deadline 2023-02-25 00:20:34.5471163 +0000 GMT m=+601.181318201, actual: 1677284434547116900
FAIL
coverage: 64.8% of statements
FAIL github.com/containerd/ttrpc 1.385s
FAIL
mingw32-make: *** [makefile:155: coverage] Error 1
Error: Process completed with exit code 1.
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.