containerd / containerd/ttrpc-rust

Add single connection support to Server

Open
#293 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
369
Forks
60
PR merge metrics
No merged PRs in 30d

Description

The `src/asynchronous/server.rs` currently assumes that there is a stream of incoming connections. For my scenario (NRI plugin) this is disadvantageous because I am already connected. Wrapping the connection into a Listener. with a `once` stream requires `'static`.

There is also the downside that `spawn_connection_handler` hides potential errors:

```rust
spawn(async move {
conn.run()
.await
.map_err(|e| {
trace!("connection run error. {}", e);
})
.ok();
});
```
#292 proposes a solution by creating a `start_connected` method.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.