containerd / containerd/nri

[API Enhance Request] Rename UpdateContainersRequest type name

Open
#146 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
406
Forks
102
Avg merge
1d 10h
Merged PRs (30d)
8

Description

Currently, there are two types with very similar names defined in api.proto: `UpdateContainersRequest` and `UpdateContainerRequest`. Although the functional positioning of these two types is completely different, their names only differ by an's', which makes the relevant code very confusing. Similarly, there are also `UpdateContainersResponse` and `UpdateContainerResponse` has same problem.

Please consider modifying the type names of `UpdateContainersRequest` and `UpdateContainersResponse` in version 1.0 to make them more distinguishable. For example, change them to `UnsolicitedUpdateContainers{Request, Response}` or something that is shorter.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.