containerd / containerd/go-cni
`Remove` suppresses errors unnecessarily
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 162
- Forks
- 69
- PR merge metrics
- No merged PRs in 30d
Description
[`(*libcni).Remove` ignores not found errors](https://github.com/containerd/go-cni/blob/8faf1dad09bbfb3abb8b681bf9b9b34884df2bab/cni.go#L252-L254), which suppresses valid errors from plugins that are cannot find the resource required to properly delete an interface.
A blanket ignore prevents the runtime from identifying and issue, and can cause future errors if the runtime tries to re-use the same interface name.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in cni.go at the (*libcni).Remove implementation around lines 252-254 and trace how plugin errors are handled. Change the behavior so valid not-found errors from plugins are not blanket-suppressed, then verify that Remove reports errors needed to diagnose failed interface deletion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100