containerd / containerd/continuity
Should os.ModeCharDevice be taken into account?
- Dominant language
- Go
- Stars
- 153
- Forks
- 74
- PR merge metrics
- No merged PRs in 30d
Description
Relates to https://github.com/moby/moby/pull/38758 / https://github.com/moby/moby/pull/38404#issuecomment-465151750 / https://github.com/golang/go/commit/a2a3dd00c934fa15ad880ee5fe1f64308cbc73a7
Due to a change in Go 1.12, some file modes are no longer being returned as `os. ModeDevice`, but as `os.ModeCharDevice`. This caused pulling images to break on docker (https://github.com/moby/moby/pull/38404#issuecomment-465151750).
I'm not very familiar with this repository, but a quick search showed some similar uses in this package, so I _suspect_ some of those will have to be updated accordingly.
https://github.com/containerd/continuity/blob/004b46473808b3e7a4a3049c20e4376c91eb966d/fs/copy.go#L137-L140
https://github.com/containerd/continuity/blob/c2ac4ecc959316e616c37fd95143e972811bd12e/resource.go#L552-L553
https://github.com/containerd/continuity/blob/c2ac4ecc959316e616c37fd95143e972811bd12e/resource.go#L434-L437
https://github.com/containerd/continuity/blob/c2ac4ecc959316e616c37fd95143e972811bd12e/context.go#L501-L502
https://github.com/containerd/continuity/blob/c2ac4ecc959316e616c37fd95143e972811bd12e/context.go#L192
https://github.com/containerd/continuity/blob/c2ac4ecc959316e616c37fd95143e972811bd12e/devices/devices_unix.go#L46
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.