const-ae / const-ae/tidygenomics

Wishlists and potential pull requests

Open
#9 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
R
Stars
106
Forks
5
PR merge metrics
No merged PRs in 30d

Description

I am really enjoying this package and I think a few functionalities may be added to this package. Wondering what your thoughts are?

- check data.frames: avoid a few common pitfalls in bioinformatics like `chr#` vs `#`, inconsistent headers etc.

Currently, the error message is a bit cryptic when chr numbering does not match:
```r
x1 <- data.frame(id = 1:4,
chromosome = c("chr1", "chr1", "chr2", "chr2"),
start = c(100, 200, 300, 400),
end = c(150, 250, 350, 450))

x2 <- data.frame(id = 1:4,
chromosome = c("1", "2", "2", "1"),
start = c(140, 210, 400, 300),
end = c(160, 240, 415, 320))

tidygenomics::genome_intersect(x1, x2, by=c("chromosome", "start", "end"), mode="both")
> tidygenomics::genome_intersect(x1, x2, by=c("chromosome", "start", "end"), mode="both")
Error: arrange() failed at implicit mutate() step.
✖ Could not create a temporary column for `..1`.
ℹ `..1` is `x`.
Run `rlang::last_error()` to see where the error occurred.
```

- strict conversion (in column headers) when converting between data.frame and GRanges
- other functionalities like `merge`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.