const-ae / const-ae/proDA

NA dropout_curve parameters

Open
#19 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
R
Stars
24
Forks
11
PR merge metrics
No merged PRs in 30d

Description

If the proDA fit is performed using a subset of rows (n_subsample), and if that subset (the first `n_subsample` rows of the dataset) has no missing values for a particular sample (column), then `dropout_curves()` can't generate parameter estimates, and returns `NA` for the curve coefficients of that sample. When later those dropout curve parameters (including the NA's) are used to predict features for the rest of the dataset, and if/when dropouts are now encounted in the samples having NA-parameter curve coefficients, the `objective_fcn` call seems to go "boom". I'd guess the right "fix" would be to recalc the dropout curve parameters "one last time" after the model has converged, using all the data (at least in this edge case).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.