console-rs / console-rs/console

False negative on VSCode debugger terminal

Open
#143 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.2k
Forks
144
Avg merge
8h 24m
Merged PRs (30d)
4

Description

This line (Previously on windows_term.rs:74 at the time of opening this issue) is returning a false negative for the "Integrated Terminal" and "External Terminal" options when launching through VS Code.

The terminal in Integrated or External mode supports inputs and all other functionalities of the launched shell, but this line is returning false indicating that the launched console is not a terminal.

I would like to fix this but I don't have enough information about this, maybe a little help with the concepts here can help me send a pull request ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/windows_term/mod.rs line 64, the location identified in the report, and investigate how terminal detection behaves when a shell is launched through VS Code's Integrated Terminal and External Terminal modes. Done means those modes are recognized as terminals while retaining their supported shell input and functionality, with the behavior verified in the relevant Windows setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, vscode
Domain
cli, devtools, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.